[GHC] #12584: Renamer is not applied properly to the expressions in declaration splices

[GHC]

#12584: Renamer is not applied properly to the expressions in declaration splices
-------------------------------------+-------------------------------------
        Reporter:  Shayan-Najd       |                Owner:
            Type:  bug               |               Status:  patch
        Priority:  high              |            Milestone:  8.0.2
       Component:  Compiler          |              Version:  8.0.1
      Resolution:                    |             Keywords:  newcomer
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D2539
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Ben Gamari <ben@…>):

 In [changeset:"bce99086e9f54909f51ff5a74cb8c666083bb021/ghc" bce9908/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="bce99086e9f54909f51ff5a74cb8c666083bb021"
 RnExpr: Actually fail if patterns found in expression

 This fixes #12584, where wildcard patterns were snuck into an
 expression, which then crashed the typechecker in TcExpr since EWildPats
 aren't supposed to appear in the AST after renaming.

 The problem was that `rnTopSpliceDecl` failed to check for errors from
 `rnSplice` (as done by other callers to `rnSplice`).

 Thanks to Shayan for reporting this!

 Reviewers: simonpj, austin

 Reviewed By: simonpj

 Subscribers: simonpj, thomie

 Differential Revision: https://phabricator.haskell.org/D2539

 GHC Trac Issues: #12584
 }}}

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12584#comment:8>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler