[GHC] #12839: mmap functions not properly guarded by RTS_LINKER_USE_MMAP in Linker.c

GHC ghc-devs at haskell.org
Wed Nov 16 04:08:39 UTC 2016


#12839: mmap functions not properly guarded by RTS_LINKER_USE_MMAP in Linker.c
-------------------------------------+-------------------------------------
        Reporter:  shlevy            |                Owner:
            Type:  bug               |               Status:  new
        Priority:  normal            |            Milestone:
       Component:  Runtime System    |              Version:  8.1
  (Linker)                           |
      Resolution:                    |             Keywords:
Operating System:  Other             |         Architecture:
 Type of failure:  Compile-time      |  Unknown/Multiple
  crash or panic                     |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Ben Gamari <ben@…>):

 In [changeset:"a637eeb7a1852adfd99b06d2c0a3496e4f238a0c/ghc"
 a637eeb7/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="a637eeb7a1852adfd99b06d2c0a3496e4f238a0c"
 Don't use mmap symbols when !RTS_LINKER_USE_MMAP

 Some usages of symbols from sys/mman.h are guarded by
 RTS_LINKER_USE_MMAP by C conditionals, not CPP conditionals. Since those
 branches are dead anyway when !RTS_LINKER_USE_MMAP, we just stub out the
 relevant symbols rather than increasing CPP branching.

 Fixes #12839.

 Reviewers: simonmar, austin, bgamari, erikd

 Reviewed By: simonmar, bgamari, erikd

 Subscribers: thomie

 Differential Revision: https://phabricator.haskell.org/D2710

 GHC Trac Issues: #12839
 }}}

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12839#comment:2>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list