[GHC] #12622: Unboxed static pointers lead to missing SPT entries

GHC ghc-devs at haskell.org
Wed Nov 16 00:44:33 UTC 2016


#12622: Unboxed static pointers lead to missing SPT entries
-------------------------------------+-------------------------------------
        Reporter:  mboes             |                Owner:
                                     |  facundo.dominguez
            Type:  bug               |               Status:  patch
        Priority:  normal            |            Milestone:
       Component:  Compiler          |              Version:  8.1
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D2709
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by facundo.dominguez):

 Fixed the id of the floated binding in master
 {{{
 commit 31d5b6efa24985d0a8be5354e6a9a38e016db0ff
 Author: Facundo Domínguez <facundo.dominguez at tweag.io>
 Date:   Tue Nov 15 21:39:40 2016 -0300

     fixup! Stop the simplifier from removing StaticPtr binds.

 diff --git a/compiler/simplCore/SetLevels.hs
 b/compiler/simplCore/SetLevels.hs
 index fc55564..f2f373d 100644
 --- a/compiler/simplCore/SetLevels.hs
 +++ b/compiler/simplCore/SetLevels.hs
 @@ -1115,7 +1115,8 @@ newLvlVar lvld_rhs is_bot
      rhs_ty = exprType de_tagged_rhs
      mk_id uniq
        -- See Note [Grand plan for static forms] in SimplCore.
 -      | isJust (collectStaticPtrSatArgs lvld_rhs)
 +      | isJust $ collectStaticPtrSatArgs $ snd $ collectTyBinders $
 +                                                   deTagExpr lvld_rhs
        = mkExportedVanillaId (mkSystemVarName uniq (mkFastString
 "static_ptr"))
                              rhs_ty
        | otherwise
 }}}

 It remains fixing the core linter now.

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12622#comment:6>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list