[GHC] #11772: GHC.CString.unpackCStringUtf8# is inlineable, shouldn't be?
GHC
ghc-devs at haskell.org
Wed Mar 30 19:20:23 UTC 2016
#11772: GHC.CString.unpackCStringUtf8# is inlineable, shouldn't be?
-------------------------------------+-------------------------------------
Reporter: bgamari | Owner:
Type: bug | Status: patch
Priority: normal | Milestone: 8.0.1
Component: Core Libraries | Version: 7.10.3
Resolution: | Keywords:
Operating System: Unknown/Multiple | Architecture:
| Unknown/Multiple
Type of failure: None/Unknown | Test Case:
Blocked By: | Blocking:
Related Tickets: | Differential Rev(s): Phab:D2057
Wiki Page: |
-------------------------------------+-------------------------------------
Comment (by Ben Gamari <ben@…>):
In [changeset:"58bbb40ba23860df2ede1275493ef32ba69a2083/ghc"
58bbb40b/ghc]:
{{{
#!CommitTicketReference repository="ghc"
revision="58bbb40ba23860df2ede1275493ef32ba69a2083"
ghc-prim: Mark unpackCStringUtf8# and unpackNBytes# as NOINLINE
There is no benefit to be had from inlining this function and it may
defeat rewrite rules if inlined early. See #11772..
Test Plan: Validate, nofib
Reviewers: simonpj, austin
Subscribers: thomie
Differential Revision: https://phabricator.haskell.org/D2057
GHC Trac Issues: #11772
}}}
--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11772#comment:4>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler
More information about the ghc-tickets
mailing list