[GHC] #11758: Drop x86_64 binutils <2.17 hack

GHC ghc-devs at haskell.org
Sat Mar 26 11:07:44 UTC 2016


#11758: Drop x86_64 binutils <2.17 hack
-------------------------------------+-------------------------------------
           Reporter:  bgamari        |             Owner:
               Type:  task           |            Status:  new
           Priority:  normal         |         Milestone:  8.2.1
          Component:  Compiler       |           Version:  8.0.1-rc2
  (NCG)                              |
           Keywords:                 |  Operating System:  Unknown/Multiple
       Architecture:                 |   Type of failure:  None/Unknown
  Unknown/Multiple                   |
          Test Case:                 |        Blocked By:
           Blocking:                 |   Related Tickets:
Differential Rev(s):                 |         Wiki Page:
-------------------------------------+-------------------------------------
 `X86.CodeGen.genSwitch` contains this comment,
 {{{
                  else -- HACK: On x86_64 binutils<2.17 is only able to
 generate
                       -- PC32 relocations, hence we only get 32-bit
 offsets in
                       -- the jump table. As these offsets are always
 negative
                       -- we need to properly sign extend them to 64-bit.
 This
                       -- hack should be removed in conjunction with the
 hack in
                       -- PprMach.hs/pprDataItem once binutils 2.17 is
 standard.
 }}}

 binutils 2.17 is now quite standard; even CentOS 5 shipped with 2.17. I
 think it is likely safe to remove this hack at this point.

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11758>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list