[GHC] #11755: Seed unsafeGlobalDynFlags with enough information to use ppr
GHC
ghc-devs at haskell.org
Sat Mar 26 01:01:11 UTC 2016
#11755: Seed unsafeGlobalDynFlags with enough information to use ppr
-------------------------------------+-------------------------------------
Reporter: bgamari | Owner: bgamari
Type: task | Status: patch
Priority: normal | Milestone:
Component: Compiler | Version: 7.10.3
Resolution: | Keywords:
Operating System: Unknown/Multiple | Architecture:
| Unknown/Multiple
Type of failure: None/Unknown | Test Case:
Blocked By: | Blocking:
Related Tickets: | Differential Rev(s): Phab:D2036
Wiki Page: |
-------------------------------------+-------------------------------------
Comment (by Ben Gamari <ben@…>):
In [changeset:"4e98b4ff98e127aa9ef4fa1e85bdf0efa41f0902/ghc" 4e98b4f/ghc]:
{{{
#!CommitTicketReference repository="ghc"
revision="4e98b4ff98e127aa9ef4fa1e85bdf0efa41f0902"
DynFlags: Initialize unsafeGlobalDynFlags enough to be useful
Previously unsafeGlobalDynFlags would bottom if used prior to
initialization. This meant that any attempt to use the pretty-printer
early in the initialization process of the compiler would fail. This is
quite inconvenient.
Here we initialize unsafeGlobalDynFlags with defaultDynFlags, bottoming
only if settings is accessed.
See #11755.
Test Plan: Validate
Reviewers: austin
Reviewed By: austin
Subscribers: thomie, gridaphobe
Differential Revision: https://phabricator.haskell.org/D2036
GHC Trac Issues: #11755
}}}
--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11755#comment:2>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler
More information about the ghc-tickets
mailing list