[GHC] #12146: syntax repair suggestion is too eager to suggest TemplateHaskell
GHC
ghc-devs at haskell.org
Thu Jul 7 15:20:30 UTC 2016
#12146: syntax repair suggestion is too eager to suggest TemplateHaskell
-------------------------------------+-------------------------------------
Reporter: j.waldmann | Owner:
Type: feature request | Status: patch
Priority: normal | Milestone:
Component: Compiler | Version: 8.0.1
Resolution: | Keywords: newcomer
Operating System: Unknown/Multiple | Architecture:
Type of failure: Incorrect | Unknown/Multiple
warning at compile-time | Test Case:
Blocked By: | Blocking:
Related Tickets: #7396 | Differential Rev(s):
Wiki Page: |
-------------------------------------+-------------------------------------
Comment (by thomie):
adityadivekar: I pushed the first two patches, but the last one did not
apply cleanly to HEAD. The testcase also seems unnecessarily complicated
(I guess you copied it from another test, but I don't understand why this
hack is necessary):
{{{
:set -v1
System.IO.writeFile "T12146.hs" "module Main where { ipmort Data.Char; }"
-- hack: avoid the need for sleep by using specific timestamps:
:! touch -t 01010000 T12146.hs
:load T12146
}}}
Two things are still missing:
* a simple `compile_fail` test. Use `T4042` as an example.
* a small comment for `badImplicitSplice` (`compiler/rename/RnSource.hs`),
explaining why the error messages shouldn't mention `TemplateHaskell`,
referring to this ticket (#12146).
If you could, please create a new patch for this, and I'll apply it.
--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12146#comment:9>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler
More information about the ghc-tickets
mailing list