[GHC] #11430: ApiAnnotations: work SourceText in for all integer literals

GHC ghc-devs at haskell.org
Sat Jan 16 13:52:49 UTC 2016


#11430: ApiAnnotations: work SourceText in for all integer literals
-------------------------------------+-------------------------------------
        Reporter:  alanz             |                Owner:  alanz
            Type:  bug               |               Status:  new
        Priority:  normal            |            Milestone:  8.0.1
       Component:  Compiler          |              Version:  8.1
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
 Type of failure:  Incorrect API     |  Unknown/Multiple
  annotation                         |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D1781
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Alan Zimmerman <alan.zimm@…>):

 In [changeset:"3a1babd6243edd96073ed3e3a5fb6e0aaf11350e/ghc" 3a1babd/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="3a1babd6243edd96073ed3e3a5fb6e0aaf11350e"
 Work SourceText in for all integer literals

 Summary:
 Certain syntactic elements have integers in them, such as fixity
 specifications, SPECIALISE pragmas and so on.

 The lexer will accept mult-radix literals, with arbitrary leading zeros
 in these.

 Bring in a SourceText field to each affected AST element to capture the
 original literal text for use with API Annotations.

 Affected hsSyn elements are

 ```
      -- See note [Pragma source text]
      data Activation = NeverActive
                      | AlwaysActive
                      | ActiveBefore SourceText PhaseNum
                           -- Active only *strictly before* this phase
                      | ActiveAfter SourceText PhaseNum
                            -- Active in this phase and later
                      deriving( Eq, Data, Typeable )
                                -- Eq used in comparing rules in HsDecls

      data Fixity = Fixity SourceText Int FixityDirection
        -- Note [Pragma source text]
        deriving (Data, Typeable)
  ```

 and

 ```
       | HsTickPragma         -- A pragma introduced tick
          SourceText           -- Note [Pragma source text] in BasicTypes
          (StringLiteral,(Int,Int),(Int,Int))
                                           -- external span for this tick
          ((SourceText,SourceText),(SourceText,SourceText))
             -- Source text for the four integers used in the span.
             -- See note [Pragma source text] in BasicTypes
          (LHsExpr id)
 ```

 Updates haddock submodule

 Test Plan: ./validate

 Reviewers: goldfire, bgamari, austin

 Reviewed By: bgamari

 Subscribers: thomie, mpickering

 Differential Revision: https://phabricator.haskell.org/D1781

 GHC Trac Issues: #11430
 }}}

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11430#comment:3>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list