[GHC] #5654: Profiling semantics bug

[GHC]

#5654: Profiling semantics bug
-------------------------------------+-------------------------------------
        Reporter:  simonmar          |                Owner:
            Type:  bug               |               Status:  new
        Priority:  low               |            Milestone:  8.2.1
       Component:  Profiling         |              Version:  7.2.1
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
                                     |  profiling/should_run/scc004
      Blocked By:                    |             Blocking:
 Related Tickets:  #10007            |  Differential Rev(s):
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Ben Gamari <ben@…>):

 In [changeset:"2a02040b2e23daa4f791afc290c33c9bbe3c620c/ghc"
 2a02040b/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="2a02040b2e23daa4f791afc290c33c9bbe3c620c"
 Fix bug in previous fix for #5654

 I forgot to account for BCOs, which have a different layout from
 functions.  This caused crashes when using profiling with GHCi (via
 -fexternal-interpreter -prof), which unfortunately is not tested at all
 by validate, even when profiling is enabled.  I'm going to add some
 testing that would have caught this in a separate patch.

 Test Plan:
 ```
 cd nofib/spectral/puzzle && make NoFibWithGHCi=YES
 EXTRA_RUNTEST_OPTS='-fexternal-interpreter -prof'
 ```
 New testsuite tests coming in a separate diff.

 Reviewers: niteria, austin, erikd, bgamari

 Reviewed By: bgamari

 Subscribers: thomie

 Differential Revision: https://phabricator.haskell.org/D2868

 GHC Trac Issues: #5654
 }}}

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/5654#comment:19>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler