[GHC] #11809: Template Haskell record splices are not renamer-resolved correctly.

GHC ghc-devs at haskell.org
Sun Apr 10 21:39:31 UTC 2016


#11809: Template Haskell record splices are not renamer-resolved correctly.
-------------------------------------+-------------------------------------
        Reporter:  bollmann          |                Owner:  bollmann
            Type:  bug               |               Status:  merge
        Priority:  normal            |            Milestone:  8.0.1
       Component:  Template Haskell  |              Version:  8.0.1
      Resolution:                    |             Keywords:  Template
                                     |  Haskell Renamer Records
Operating System:  Unknown/Multiple  |         Architecture:
 Type of failure:  GHC rejects       |  Unknown/Multiple
  valid program                      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D2091
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Ben Gamari <ben@…>):

 In [changeset:"2f82da761defba2cfdc55ca08d774ca7e1240463/ghc" 2f82da7/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="2f82da761defba2cfdc55ca08d774ca7e1240463"
 Fix Template Haskell bug reported in #11809.

 Record selectors of data types spliced in with Template Haskell are not
 renamer-resolved correctly in GHC HEAD. The culprit is
 `newRecordSelector` which violates notes `Note [Binders in Template
 Haskell] in Convert.hs` and `Note [Looking up Exact RdrNames] in
 RnEnv.hs`. This commit fixes `newRecordSelector` accordingly.

 Test Plan: ./validate

 Reviewers: thomie, mpickering, bgamari, austin, simonpj, goldfire

 Reviewed By: goldfire

 Differential Revision: https://phabricator.haskell.org/D2091

 GHC Trac Issues: #11809
 }}}

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11809#comment:4>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list