[GHC] #11019: ApiAnnotations: Make all RdrName occurences Located

[GHC]

#11019: ApiAnnotations: Make all RdrName occurences Located
-------------------------------------+-------------------------------------
        Reporter:  alanz             |                Owner:  alanz
            Type:  bug               |               Status:  new
        Priority:  normal            |            Milestone:  8.0.1
       Component:  Compiler          |              Version:  7.10.2
      Resolution:                    |             Keywords:
                                     |  ApiAnnotations
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:1512
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Ben Gamari <ben@…>):

 In [changeset:"3df9563e590bbfbfe1bc9171a0e8fc93ceef690d/ghc"
 3df9563e/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="3df9563e590bbfbfe1bc9171a0e8fc93ceef690d"
 ApiAnnotations: Make all RdrName occurences Located

 At the moment the API Annotations can only be used on the ParsedSource,
 as there are changes made to the RenamedSource that prevent it from
 being used to round trip source code.

 It is possible to build a map from every Located Name in the
 RenamedSource from its location to the Name, which can then be used when
 resolved names are required when changing the ParsedSource.

 However, there are instances where the identifier is not located,
 specifically

   (GHC.VarPat name)
   (GHC.HsVar name)
   (GHC.UserTyVar name)
   (GHC.HsTyVar name)

 Replace each of the name types above with (Located name)

 Updates the haddock submodule.

 Test Plan: ./validate

 Reviewers: austin, goldfire, bgamari

 Reviewed By: bgamari

 Subscribers: goldfire, thomie, mpickering

 Differential Revision: https://phabricator.haskell.org/D1512

 GHC Trac Issues: #11019
 }}}

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11019#comment:5>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler