[GHC] #10276: ApiAnnotations : ITopenExpQuote needs SourceText
GHC
ghc-devs at haskell.org
Mon Nov 16 19:10:27 UTC 2015
#10276: ApiAnnotations : ITopenExpQuote needs SourceText
-------------------------------------+-------------------------------------
Reporter: alanz | Owner: alanz
Type: bug | Status: patch
Priority: normal | Milestone: 8.0.1
Component: Compiler | Version: 7.10.1
(Parser) |
Resolution: | Keywords:
Operating System: Unknown/Multiple | Architecture:
| Unknown/Multiple
Type of failure: None/Unknown | Test Case:
Blocked By: | Blocking:
Related Tickets: | Differential Rev(s): Phab:D1479
Wiki Page: |
-------------------------------------+-------------------------------------
Comment (by Alan Zimmerman <alan.zimm@…>):
In [changeset:"ee9148284dd5a66ed4970aff5218d973997cb9cf/ghc" ee91482/ghc]:
{{{
#!CommitTicketReference repository="ghc"
revision="ee9148284dd5a66ed4970aff5218d973997cb9cf"
ApiAnnotations : ITopenExpQuote needs SourceText
Summary:
In the lexer, ITopenExpQuote can be recognised for '[e|' or '[|'.
The token definition needs to capture the original SourceText, and pass
it through to ExpBr, which also needs a SrcText field.
It is easier to simply add a flag to the token identifying the variant
and to generate a different AnnKeywordId based on this.
Test Plan: ./validate
Reviewers: mpickering, bgamari, austin
Reviewed By: bgamari
Subscribers: thomie
Differential Revision: https://phabricator.haskell.org/D1479
GHC Trac Issues: #10276
}}}
--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10276#comment:5>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler
More information about the ghc-tickets
mailing list