[GHC] #11017: ApiAnnotations: BooleanFormula is not properly Located

GHC ghc-devs at haskell.org
Sun Nov 1 12:42:56 UTC 2015


#11017: ApiAnnotations: BooleanFormula is not properly Located
-------------------------------------+-------------------------------------
        Reporter:  alanz             |                Owner:  alanz
            Type:  bug               |               Status:  patch
        Priority:  normal            |            Milestone:  8.0.1
       Component:  Compiler          |              Version:  7.10.2
      Resolution:                    |             Keywords:
                                     |  ApiAnnotations
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D1384
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Ben Gamari <ben@…>):

 In [changeset:"f16827f84855bef94b1b69f49bd1734627946f02/ghc" f16827f/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="f16827f84855bef94b1b69f49bd1734627946f02"
 ApiAnnotations: BooleanFormula is not properly Located

 At the moment BooleanFormula is defined as

   data BooleanFormula a = Var a | And [BooleanFormula a]
                         | Or [BooleanFormula a]
        deriving (Eq, Data, Typeable, Functor, Foldable, Traversable)

 An API Annotation can only be attached to an item of the form Located a.

 Replace this with a properly Located version, and attach the appropriate
 API Annotations to it

 Updates haddock submodule.

 Test Plan: ./validate

 Reviewers: austin, bgamari

 Reviewed By: bgamari

 Subscribers: thomie, mpickering

 Differential Revision: https://phabricator.haskell.org/D1384

 GHC Trac Issues: #11017
 }}}

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11017#comment:3>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list