[GHC] #10449: Out-of-tree tests broken on MinGW + native Python due to quoting of config.compiler
GHC
ghc-devs at haskell.org
Wed May 27 15:47:17 UTC 2015
#10449: Out-of-tree tests broken on MinGW + native Python due to quoting of
config.compiler
-------------------------------+-------------------------------------------
Reporter: Rufflewind | Owner:
Type: bug | Status: patch
Priority: normal | Milestone: 7.12.1
Component: Test Suite | Version: 7.10.1
Resolution: | Keywords:
Operating System: Windows | Architecture: Unknown/Multiple
Type of failure: Other | Test Case:
Blocked By: | Blocking:
Related Tickets: #10441 | Differential Revisions: Phab:D911
-------------------------------+-------------------------------------------
Comment (by Rufflewind):
Unfortunately, the `wrap` call still breaks the magic. The conversion
seems to be documented here:
http://www.mingw.org/wiki/Posix_path_conversion
What is the reason for quoting `compiler.config`? A quick grep shows the
following code use `compiler.config`:
{{{
./testsuite/config/ghc:config.compiler = 'ghc'
./testsuite/config/ghc: h = os.popen(config.compiler + ' --info', 'r')
./testsuite/config/ghc: h = os.popen(config.compiler + ' +RTS --info',
'r')
./testsuite/mk/test.mk: -e 'config.compiler=$(call quote_path,$(TEST_HC))'
\
./testsuite/driver/testglobals.py: self.compiler = ''
./testsuite/driver/runtests.py: # testframe -e
'config.compiler=ghc-5.04'
}}}
There might be others I've missed, but I think in many situations the
quotes will either get stripped anyway, or can be rewritten using
`subprocess` so as to avoid the need for them. If quotes are necessary,
they could be just added at those specific places.
--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10449#comment:9>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler
More information about the ghc-tickets
mailing list