[GHC] #10287: ApiAnnotations : BooleanFormula construction discards original

[GHC]

#10287: ApiAnnotations : BooleanFormula construction discards original
-------------------------------------+-------------------------------------
        Reporter:  alanz             |                   Owner:  alanz
            Type:  bug               |                  Status:  patch
        Priority:  normal            |               Milestone:  7.10.2
       Component:  Compiler          |                 Version:  7.10.1
      Resolution:                    |                Keywords:
Operating System:  Unknown/Multiple  |  ApiAnnotations
 Type of failure:  None/Unknown      |            Architecture:
      Blocked By:                    |  Unknown/Multiple
 Related Tickets:                    |               Test Case:
                                     |                Blocking:
                                     |  Differential Revisions:  Phab:D837
-------------------------------------+-------------------------------------

Comment (by Alan Zimmerman <alan.zimm@…>):

 In [changeset:"24707d72d6137cb970878ef243c090a6bf6601e0/ghc"]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="24707d72d6137cb970878ef243c090a6bf6601e0"
 ApiAnnotations : BooleanFormula construction discards original

 Summary:
 The MINIMAL pragma is captured in the parser using a BooleanFormula.

 The constructors (mkBool,mkAnd,mkOr) are smart and try to minimise the
 boolean formula as it is constructed.

 This discards the original information, making round tripping
 impossible.

 Note: there is another version which provides a more API Annotations
 friendly version of the MINIMAL pragma, but this requires changes to
 haddock, which will cause problems for 7.10.2.

 See https://github.com/alanz/ghc/tree/wip/10287

 Test Plan: ./validate

 Reviewers: hvr, austin

 Reviewed By: austin

 Subscribers: bgamari, Fuuzetsu, thomie, mpickering

 Differential Revision: https://phabricator.haskell.org/D837

 GHC Trac Issues: #10287
 }}}

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10287#comment:3>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler