[GHC] #10312: ApiAnnotations: misplaced AnnComma for squals production

[GHC]

#10312: ApiAnnotations: misplaced AnnComma for squals production
-------------------------------------+-------------------------------------
        Reporter:  alanz             |                   Owner:  alanz
            Type:  bug               |                  Status:  patch
        Priority:  normal            |               Milestone:  7.10.2
       Component:  Compiler          |                 Version:  7.10.1
  (Parser)                           |                Keywords:
      Resolution:                    |  ApiAnnotations
Operating System:  Unknown/Multiple  |            Architecture:
 Type of failure:  None/Unknown      |  Unknown/Multiple
      Blocked By:                    |               Test Case:
 Related Tickets:                    |                Blocking:
                                     |  Differential Revisions:  Phab:D846
-------------------------------------+-------------------------------------

Comment (by Alan Zimmerman <alan.zimm@…>):

 In [changeset:"713612674634754edd17264e688f0479d943d8d2/ghc"]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="713612674634754edd17264e688f0479d943d8d2"
 ApiAnnotations: misplaced AnnComma for squals production

 Summary:
 The parser production for squals has

     : squals ',' transformqual
              {% addAnnotation (gl $ last $ unLoc $1) AnnComma (gl $2) >>
                 ams (sLL $1 $> ()) (fst $ unLoc $3) >>
                 return (sLL $1 $> [sLL $1 $> ((snd $ unLoc $3) (reverse
 (unLoc $1)))]) }

 This attaches the comma to the wrong part of the squals, as it is
 generated in reverse order.

 Test Plan: ./validate

 Reviewers: hvr, austin

 Reviewed By: austin

 Subscribers: bgamari, thomie, mpickering

 Differential Revision: https://phabricator.haskell.org/D846

 GHC Trac Issues: #10312
 }}}

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10312#comment:3>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler