[GHC] #10164: Cleanup test framework string formatting

GHC ghc-devs at haskell.org
Tue Mar 17 11:26:23 UTC 2015


#10164: Cleanup test framework string formatting
-------------------------------------+-------------------------------------
        Reporter:  thomie            |                   Owner:
            Type:  task              |                  Status:  new
        Priority:  normal            |               Milestone:
       Component:  Test Suite        |                 Version:  7.8.4
      Resolution:                    |                Keywords:
Operating System:  Unknown/Multiple  |            Architecture:
 Type of failure:  None/Unknown      |  Unknown/Multiple
      Blocked By:                    |               Test Case:
 Related Tickets:                    |                Blocking:
                                     |  Differential Revisions:
-------------------------------------+-------------------------------------

Comment (by thomie):

 In cc07a0ba64b554ffd1ff85757b02cd79d30ed57a/ghc:
 {{{
 commit cc07a0ba64b554ffd1ff85757b02cd79d30ed57a
 Author: Thomas Miedema <thomasmiedema at gmail.com>
 Date:   Fri Mar 13 21:07:15 2015 +0100

     Move the function strip_quotes to testutil.py

     If one runs the testsuite with a profiling compiler, during the import
     of `testlib.py`, `testlib.py` sets the global variable `gs_working`.
 To
     do so, it executes a few statements which require the function
     `strip_quotes` to be in scope. But that function only gets defined at
     the very end of testlib.py.

     This patch moves the definition of `strip_quotes` to testutil.py,
 which
     is imported at the very top of testlib.py. This unbreaks the nightly
     builders.

     Reviewed By: austin

     Differential Revision: https://phabricator.haskell.org/D728
 }}}

 Merged to 7.10 in 65753a9d3414d52b9a97cb23e3c8cff84f7528e5.

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10164#comment:2>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list