[GHC] #10441: msys native python testsuite support doesn't work in some situations

[GHC]

#10441: msys native python testsuite support doesn't work in some situations
-------------------------------------+-------------------------------------
        Reporter:  ezyang            |                   Owner:
            Type:  bug               |                  Status:  patch
        Priority:  high              |               Milestone:  7.12.1
       Component:  Test Suite        |                 Version:  7.11
      Resolution:                    |                Keywords:
Operating System:  Windows           |            Architecture:
 Type of failure:  None/Unknown      |  Unknown/Multiple
      Blocked By:                    |               Test Case:
 Related Tickets:                    |                Blocking:
                                     |  Differential Revisions:  Phab:D952
-------------------------------------+-------------------------------------

Comment (by Thomas Miedema <thomasmiedema@…>):

 In [changeset:"bb9967121f2383b857680b47b6bc20607f8fd1ff/ghc"]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="bb9967121f2383b857680b47b6bc20607f8fd1ff"
 Revert "The test runner now also works under the msys-native Python."

 To make the test runner work under msys-native Python...

 Commit 5258566ee5c89aa757b0cf1433169346319c018f broke the msys testsuite
 driver (#10441). It changed the quoting of `config.compiler` from single
 quotes to double quote, which turns out to not be compatible with what
 the function `passThroughCmd` expected.

 We could fix `passThroughCmd` to handle the case where `config.compiler`
 is double quoted, and scatter some notes around to make sure the quoting
 done in various places of the testsuite driver stay compatible.

 Instead, this commit reverts 101c62e26286353dd3fac1ef54323529b64c9902,
 which introdced the function `passThroughCmd` in the first place
 (#9626). ezyang reports that doing this revert fixes the testsuite
 driver for him using the the following version of msys2:

   msys2-keyring r8.3864337-1
   msys2-runtime 2.1.0.16351.cd3184b-1
   msys2-runtime-devel 2.1.0.16351.cd3184b-1
   msys2-w32api-headers 5.0.0.4456.c8b6742-1
   msys2-w32api-runtime 5.0.0.4455.32db221-1

 Ideally we'd know what minimum version of msys2 we require, but for now
 this fix is better than nothing.

 Only gintas ever reported the original problem, and he actually
 mentioned shortly afterwards: "This may have been fixed by a recent
 release of msys2, but I am not sure."

 Differential Revision: https://phabricator.haskell.org/D952
 }}}

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10441#comment:6>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler