[GHC] #10660: .dyn_o isn't generated for .hsig files with -dynamic-too

[GHC]

#10660: .dyn_o isn't generated for .hsig files with -dynamic-too
-------------------------------------+-------------------------------------
        Reporter:  spinda            |                   Owner:  spinda
            Type:  bug               |                  Status:  patch
        Priority:  normal            |               Milestone:  7.10.3
       Component:  Compiler          |                 Version:  7.10.1
      Resolution:                    |                Keywords:  backpack
Operating System:  Unknown/Multiple  |            Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |               Test Case:
      Blocked By:                    |                Blocking:
 Related Tickets:                    |  Differential Revisions:  Phab:D1084
-------------------------------------+-------------------------------------

Comment (by Ben Gamari <ben@…>):

 In [changeset:"d2b4df157532adf014789ae9b2496f88369e43ea/ghc" d2b4df1/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="d2b4df157532adf014789ae9b2496f88369e43ea"
 Generate .dyn_o files for .hsig files with -dynamic-too

 With -dynamic-too, .dyn_o files were not being generated for .hsig
 files.  Normally, this is handled in the pipeline; however, the branch
 for .hsig files called compileEmptyStub directly instead of going
 through runPipeline.  When compiling a Cabal package that included .hsig
 files, this triggered a linker error later on, as it expected a .dyn_o
 file to have been generated for each .hsig.

 The fix is to use runPipeline for .hsig files, just as with .hs files.
 Alternately, one could duplicate the logic for handling -dynamic-too in
 the .hsig branch, but simply calling runPipeline ends up being much
 cleaner.

 Test Plan: validate

 Reviewers: austin, ezyang, bgamari, thomie

 Reviewed By: ezyang, thomie

 Subscribers: thomie

 Differential Revision: https://phabricator.haskell.org/D1084

 GHC Trac Issues: #10660
 }}}

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10660#comment:4>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler