[GHC] #9976: Ignore newlines in code diffs on Phab

[GHC]

#9976: Ignore newlines in code diffs on Phab
-------------------------------------+-------------------------------------
              Reporter:  goldfire    |             Owner:
                  Type:  feature     |            Status:  new
  request                            |         Milestone:
              Priority:  low         |           Version:  7.8.4
             Component:  Trac & Git  |  Operating System:  Unknown/Multiple
              Keywords:              |   Type of failure:  None/Unknown
          Architecture:              |        Blocked By:
  Unknown/Multiple                   |   Related Tickets:
             Test Case:              |
              Blocking:              |
Differential Revisions:              |
-------------------------------------+-------------------------------------
 Doing code reviews in Phab is great. However, the way that the lint
 feature works encourages patchers to split lines as they means that more
 attention is drawn to split lines than perhaps should be.

 As a concrete example, I'm reading Phab:D538 this morning, and looking at
 line 402 of !DsArrows. Alan has added a new field to a data structure and
 needed to insert a `_` to make the code remain well typed... but this
 forced a line split to avoid a lint error. Now, I have to check if there
 are any changes in the second half of the line manually, because the
 character-diff highlighting fails after the line split.

 Is there a way to improve this behavior? I can think of two approaches:

 * (Better option) Teach the character-diff highlighting feature to look
 across linebreaks.

 * (Worse option) Encourage patchers ''not'' to make new line breaks until
 their final commit. Suppress lint problems about line breaks by request.

 This is, of course, minor, but it would certainly be nice!

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9976>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler