[GHC] #481: Recompilation check fails for TH
GHC
ghc-devs at haskell.org
Sat Jan 3 20:31:32 UTC 2015
#481: Recompilation check fails for TH
------------------------------------------------+--------------------------
Reporter: simonpj | Owner: simonmar
Type: bug | Status: closed
Priority: normal | Milestone: 7.2.1
Component: Template Haskell | Version: 6.4.1
Resolution: fixed | Keywords:
Operating System: Unknown/Multiple | Architecture:
Type of failure: Incorrect result at runtime | Unknown/Multiple
Blocked By: | Test Case:
| TH_recompile
| Blocking:
------------------------------------------------+--------------------------
Comment (by Edward Z. Yang <ezyang@…>):
In [changeset:"af4d99803ea7676f88f250ad56a8c31c1c8cd5bc/ghc"]:
{{{
#!CommitTicketReference repository="ghc"
revision="af4d99803ea7676f88f250ad56a8c31c1c8cd5bc"
Don't do a half-hearted recompilation check in compileOne
Summary:
The isNothing maybe_old_linkable check predates
48bc81ad466edfc80237015dbe5d78ba70eb5095, which fixed #481 by requiring
recompilation information to be passed in as an argument to compileOne.
As a result, the check here is redundant: the client has already taken
a look at the object file to see if it is available or not.
Signed-off-by: Edward Z. Yang <ezyang at cs.stanford.edu>
Test Plan: validate
Reviewers: simonmar, austin
Subscribers: carter, thomie
Differential Revision: https://phabricator.haskell.org/D594
}}}
--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/481#comment:15>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler
More information about the ghc-tickets
mailing list