[GHC] #10636: Clear up difference between `WayDyn` and `Opt_Static`

[GHC]

#10636: Clear up difference between `WayDyn` and `Opt_Static`
-------------------------------------+-------------------------------------
        Reporter:  thomie            |                Owner:  thomie
            Type:  task              |               Status:  new
        Priority:  normal            |            Milestone:
       Component:  Compiler          |              Version:  7.10.1
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Ben Gamari <ben@…>):

 In [changeset:"6d9c18cb43c1fda95932ef0f640dcf41906a2773/ghc"
 6d9c18cb/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="6d9c18cb43c1fda95932ef0f640dcf41906a2773"
 DynFlags: remove Opt_Static

 There are currently 2 different ways to test for a static or dynamic
 build:

     * Test if WayDyn is in ways
     * Test if Opt_Static is set

 The problem is that these can easily go out of sync, especially when
 using the
 GHC API.

 This commit replaces all queries of Opt_Static with an equivalent query
 of
 WayDyn. This would have prevented bug #8294 and fixes #11154.

 Reviewers: hvr, austin, bgamari

 Reviewed By: austin, bgamari

 Differential Revision: https://phabricator.haskell.org/D1607

 GHC Trac Issues: #10636
 }}}

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10636#comment:3>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler