[GHC] #9736: Constant folding rules are wrong for GHCJS

GHC ghc-devs at haskell.org
Wed Nov 19 23:03:03 UTC 2014


#9736: Constant folding rules are wrong for GHCJS
-------------------------------------+-------------------------------------
              Reporter:  luite       |            Owner:  luite
                  Type:  bug         |           Status:  new
              Priority:  normal      |        Milestone:  7.10.1
             Component:  Compiler    |          Version:  7.8.3
            Resolution:              |         Keywords:
      Operating System:              |     Architecture:  Unknown/Multiple
  Unknown/Multiple                   |       Difficulty:  Unknown
       Type of failure:              |       Blocked By:
  None/Unknown                       |  Related Tickets:
             Test Case:              |
              Blocking:              |
Differential Revisions:  Phab:D502   |
-------------------------------------+-------------------------------------

Comment (by Austin Seipp <austin@…>):

 In [changeset:"4dd87c5e3ebd0569fdd19695f3e9c82102404a4f/ghc"]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="4dd87c5e3ebd0569fdd19695f3e9c82102404a4f"
 use correct word size for shiftRightLogical and removeOp32

 Summary:
 shiftRightLogical used a host sized Word for the intermediate value,
 which would produce the wrong result when cross compiling to a target
 with a different word size than the host.

 removeOp32 used the preprocessor to bake in word size assumptions,
 rather than getting the target word size from DynFlags

 Test Plan: validate

 Reviewers: hvr, rwbarton, carter, austin

 Reviewed By: austin

 Subscribers: thomie, carter

 Differential Revision: https://phabricator.haskell.org/D502

 GHC Trac Issues: #9736
 }}}

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9736#comment:5>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list