[GHC] #8783: make ghc-pwd-bindist script /bin/sh compatible for Solaris
GHC
ghc-devs at haskell.org
Thu Apr 3 16:13:50 UTC 2014
#8783: make ghc-pwd-bindist script /bin/sh compatible for Solaris
-------------------------------------+-------------------------------------
Reporter: maeder | Owner:
Type: bug | Status: closed
Priority: normal | Milestone: 7.8.1
Component: Build System | Version: 7.8.1-rc2
Resolution: fixed | Keywords:
Operating System: Solaris | Architecture: Unknown/Multiple
Type of failure: Building GHC | Difficulty: Easy (less than 1
failed | hour)
Test Case: | Blocked By:
Blocking: | Related Tickets:
-------------------------------------+-------------------------------------
Comment (by kgardas):
Replying to [comment:19 maeder]:
> The following patch fixes the problem by replacing $(SHELL) with
/bin/sh:
>
> {{{
> --- ghc.mk~ Fri Feb 28 12:34:54 2014
> +++ ghc.mk Thu Apr 3 11:25:13 2014
> @@ -146,7 +146,7 @@
> PATH=`pwd`:$$PATH; \
> export PATH; \
> cd gmpbuild && \
> - CC=$(CCX) NM=$(NM) AR=$(AR_STAGE1) $(SHELL) ./configure \
> + CC=$(CCX) NM=$(NM) AR=$(AR_STAGE1) /bin/sh ./configure \
> --enable-shared=no \
> --host=$(HOSTPLATFORM) --build=$(BUILDPLATFORM)
> $(MAKE) -C libraries/integer-gmp/gmp/gmpbuild MAKEFLAGS=
> }}}
This patch looks highly suspicious to me. Generally speaking if we detect
some shell and save it to SHELL, then we'd probably like to use that and
not revert to ordinary /bin/sh. Why do you think your analysis is correct
and not just a side effect of your change? Have you tried to trace libtool
and see where it throws its error message? That may IMHO lead to real bug
fix instead of just a guess...
--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8783#comment:20>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler
More information about the ghc-tickets
mailing list