[GHC] #8418: [patch] comments outdated

GHC ghc-devs
Mon Oct 7 22:59:35 UTC 2013


#8418: [patch] comments outdated
-------------------------------+-------------------------------------------
        Reporter:  errge       |            Owner:
            Type:  bug         |           Status:  patch
        Priority:  normal      |        Milestone:  7.8.1
       Component:  Compiler    |          Version:  7.6.3
      Resolution:              |         Keywords:
Operating System:              |     Architecture:  Unknown/Multiple
  Unknown/Multiple             |       Difficulty:  Easy (less than 1 hour)
 Type of failure:              |       Blocked By:
  None/Unknown                 |  Related Tickets:
       Test Case:              |
        Blocking:              |
-------------------------------+-------------------------------------------
Description changed by hvr:

Old description:

> During working on GHC, I found these outdated comments and function
> names.
>
> The ForPlugins renaming is DynamicLoading.hs is motivated by the fact
> that chnage 57d6798 crippled the function in a way that now it can only
> be used while handling Plugins.  Therefore the name should warn the
> programmer to this fact.
>
> The hptInstances comment has also been outdated, when someone needed to
> add the `ModuleName -> Bool` predicate to use this same function for
> handling ghc and ghci with shared code.
>
> The attached patch is trivial renames/comments.

New description:

 During working on GHC, I found these outdated comments and function names.

 The `ForPlugins` renaming in [[GhcFile(compiler/main/DynamicLoading.hs)]]
 is motivated by the fact that change [57d67983] crippled the function in a
 way that now it can only be used while handling Plugins.  Therefore the
 name should warn the programmer to this fact.

 The hptInstances comment has also been outdated, when someone needed to
 add the `ModuleName -> Bool` predicate to use this same function for
 handling ghc and ghci with shared code.

 The attached patch is trivial renames/comments.

--

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8418#comment:2>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler



More information about the ghc-tickets mailing list