[ghc-steering-committee] #596: sized literals in Show, rec: accept

Chris Dornan chris at chrisdornan.com
Thu Jun 29 08:35:57 UTC 2023


Agreed on both points: LGTM; lets keep the CLC in the loop.

> On 29 Jun 2023, at 08:16, Simon Peyton Jones <simon.peytonjones at gmail.com> wrote:
> 
> Looks good to me.
> 
> I have suggested that @monoidal opens a CLC issue.  (This change the `base` API.)
> 
> Simon
> 
> On Thu, 29 Jun 2023 at 07:21, Joachim Breitner <mail at joachim-breitner.de <mailto:mail at joachim-breitner.de>> wrote:
>> Dear committee,
>> 
>> Krzysztof Gogolewski in
>> https://github.com/ghc-proposals/ghc-proposals/pull/596
>> amends the sized literals proposal so that GHC uses the syntax 
>> 42#Int8 instead of (intToInt8# 42#) in the stock derived Show instances
>> for data types with sized unboxed numbers.
>> 
>> Implementation is also ready.
>> 
>> Now that we have a syntax for these literals it’s clear that we want to
>> use them in the show instances. 
>> 
>> 
>> There is no risk of breaking Show-Read-roundtripping, as Read instances
>> cannot be derived (at the moment).
>> 
>> This is a change in behavior of Show, so we should think for a moment
>> how this affects stability. But none of the libraries in libraries/, in
>> particularly not base, are affected by this change, according to
>> Krzysztof.
>> 
>> So I recommend to accept this.
>> 
>> Cheers,
>> Joachim
>> 
>> 
>> 
>> -- 
>> Joachim Breitner
>>   mail at joachim-breitner.de <mailto:mail at joachim-breitner.de>
>>   http://www.joachim-breitner.de/
>> 
>> _______________________________________________
>> ghc-steering-committee mailing list
>> ghc-steering-committee at haskell.org <mailto:ghc-steering-committee at haskell.org>
>> https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
> _______________________________________________
> ghc-steering-committee mailing list
> ghc-steering-committee at haskell.org
> https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-steering-committee/attachments/20230629/34b8e432/attachment.html>


More information about the ghc-steering-committee mailing list