[ghc-steering-committee] The 'Char' kind

Simon Peyton Jones simonpj at microsoft.com
Mon Sep 21 08:35:55 UTC 2020


Thanks for alerting us.

If it was a few dozen lines I'd wave it through. But this is a 1800-line patch.   I've commented on the MR.

As to process, it sounds like a library issue, but it affects GHC's code base, and quite substantially so.  So I wonder if it might actually be salutary to write a proposal. At the same time I don't want to appear to discourage, still less sandbag, this as a contribution to GHC.

Simon

From: ghc-steering-committee <ghc-steering-committee-bounces at haskell.org> On Behalf Of Richard Eisenberg
Sent: 18 September 2020 20:44
To: Simon Peyton Jones via ghc-steering-committee <ghc-steering-committee at haskell.org>
Subject: [ghc-steering-committee] The 'Char' kind

Hi GHCSC,

Before this committee existed, Alex Vieth submitted #11342 (https://gitlab.haskell.org/ghc/ghc/-/issues/11342<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.haskell.org%2Fghc%2Fghc%2F-%2Fissues%2F11342&data=02%7C01%7Csimonpj%40microsoft.com%7C23e434cc47e14de9ce4708d85c0b3f5b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637360551746873922&sdata=NnGZFdf3tP5F93OiKvcZmYrQrRykZ4wixXQ%2FU9xiFIA%3D&reserved=0>), requesting a kind `Char`. Serokell has now provided a patch, !3598 (https://gitlab.haskell.org/ghc/ghc/-/merge_requests/3598<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.haskell.org%2Fghc%2Fghc%2F-%2Fmerge_requests%2F3598&data=02%7C01%7Csimonpj%40microsoft.com%7C23e434cc47e14de9ce4708d85c0b3f5b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637360551746873922&sdata=sM%2BmZ%2FXPGQ8RHxlioFtiUpcw3FBfrQogfnIEudEqhqM%3D&reserved=0>). The chair of the CLC has signed off on this patch (https://gitlab.haskell.org/ghc/ghc/-/merge_requests/3598#note_300231<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.haskell.org%2Fghc%2Fghc%2F-%2Fmerge_requests%2F3598%23note_300231&data=02%7C01%7Csimonpj%40microsoft.com%7C23e434cc47e14de9ce4708d85c0b3f5b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637360551746883879&sdata=XHCCmKT1i0DEfFBldTtKlQdHtDt%2F4s%2BuSlMt4HhAE%2Fk%3D&reserved=0>). But I feel we should, too.

What is a good process here? Just debate amongst ourselves? Post a GitHub Issue to call wider attention? Post a proposal? Merge without debate?

Richard
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-steering-committee/attachments/20200921/e6de19df/attachment.html>


More information about the ghc-steering-committee mailing list