[ghc-steering-committee] Please review again: Make Q (TExp a) into a newtype #195

[Simon Peyton Jones]

Iavor

See the GitHub thread.  I’m happy to accept.  But I’d love that API to be written down.

Simon

From: Simon Peyton Jones
Sent: 15 May 2020 11:13
To: Iavor Diatchki <iavor.diatchki at gmail.com>; ghc-steering-committee <ghc-steering-committee at haskell.org>
Subject: RE: [ghc-steering-committee] Please review again: Make Q (TExp a) into a newtype #195

I’ve posted a comment on GitHub with some more questions.

Iavor: please do nag if I am slow.

Simon

From: ghc-steering-committee <ghc-steering-committee-bounces at haskell.org<mailto:ghc-steering-committee-bounces at haskell.org>> On Behalf Of Iavor Diatchki
Sent: 14 May 2020 16:29
To: ghc-steering-committee <ghc-steering-committee at haskell.org<mailto:ghc-steering-committee at haskell.org>>
Subject: [ghc-steering-committee] Please review again: Make Q (TExp a) into a newtype #195

Hello,

I am the shepherd for #195, about a small change to TH, to wrap `Q (TExp a)` into a newtype.  This would be quite handy for a variety of reasons described in the proposal and the comments on the proposal thread:

https://github.com/ghc-proposals/ghc-proposals/pull/195<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fghc-proposals%2Fghc-proposals%2Fpull%2F195&data=02%7C01%7Csimonpj%40microsoft.com%7C6752f335bf23495310a008d7f81b8e5f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637250670092467337&sdata=nrEvqMXEuJf8TKHie3lSc8pPFgsVqp%2FdykYAlvSkZRs%3D&reserved=0>

During the last discussion we requested the proposal to be modified to clarify some points.  Matt has done that, so it is time for another review.  The previous discussion thread is here:

https://mail.haskell.org/pipermail/ghc-steering-committee/2019-November/001260.html<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmail.haskell.org%2Fpipermail%2Fghc-steering-committee%2F2019-November%2F001260.html&data=02%7C01%7Csimonpj%40microsoft.com%7C6752f335bf23495310a008d7f81b8e5f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637250670092477333&sdata=KSz2uFBn3WgRavO%2BPuwfZ2hCpiGcIcVjOLLAdiD3Kno%3D&reserved=0>

I still think this is a good idea, and recommend acceptance.   Since we've already discussed this once, I'll assume acceptance in about a week, if I don't hear from anyone, although I'll wait until at least Simon PJ and Richard confirm that the issues they raised last time have been addressed.

-Iavor

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-steering-committee/attachments/20200522/be3ac15b/attachment.html>