[ghc-steering-committee] #195 recommendation: accept

[Iavor Diatchki]

If there are no more issue to clear up, I'll mark this as accepted
next week Monday.  Please speak up, if you think otherwise.

On Sat, Nov 9, 2019 at 7:22 PM Eric Seidel <eric at seidel.io> wrote:
>
> I'm also in Arnaud's boat. I support improving the usability of Typed TH, and the Code newtype looks like a step in that direction. So, assuming we can satisfy Simon and Richard's questions, I support acceptance.
>
> On Wed, Nov 6, 2019, at 03:46, Spiwack, Arnaud wrote:
> > I understand that some details are lacking. But I don't think, whatever
> > the details are, that they will affect my opinion of the proposal: they
> > are over my knowledge of Template Haskell.
> >
> > This proposal seems well motivated. So, I'll count as an accept vote,
> > when the details are eventually sorted out.
> >
> > On Tue, Nov 5, 2019 at 10:45 PM Richard Eisenberg <rae at richarde.dev> wrote:
> > > I'm in the same camp as Simon here -- I'm still a little murky on how `Code` will interact with `Q`.
> > >
> > >  Richard
> > >
> > >  > On Nov 5, 2019, at 5:23 PM, Simon Peyton Jones via ghc-steering-committee <ghc-steering-committee at haskell.org> wrote:
> > >  >
> > >  > I'm basically supportive, but would like to see answers to my recent questions incorporated in the proposal before it is accepted.
> > >  > https://github.com/ghc-proposals/ghc-proposals/pull/195#issuecomment-547522510
> > >  >
> > >  > Simon
> > >  >
> > >  >
> > >  > | -----Original Message-----
> > >  > | From: ghc-steering-committee <ghc-steering-committee-bounces at haskell.org>
> > >  > | On Behalf Of Iavor Diatchki
> > >  > | Sent: 05 November 2019 16:44
> > >  > | To: ghc-steering-committee <ghc-steering-committee at haskell.org>
> > >  > | Subject: [ghc-steering-committee] #195 recommendation: accept
> > >  > |
> > >  > | Hello everyone,
> > >  > |
> > >  > | I am the shepherd for pull request #195 to wrap `Q (TExtp a)` into a
> > >  > | newtype synonym `Code a`. The main change to the language is that the
> > >  > | special Template Haskell notation for typed splices will will work
> > >  > | with `Code a` rather than `Q (TExtp a)`.
> > >  > |
> > >  > | The benefit of having the newtype is that it makes it possible to
> > >  > | abstract over `Code`. For example, you can work with typed name
> > >  > | environments like `MapF Name Code`, where `MapF` is an "indexed"
> > >  > | variant of `Map` which maps `Name a` to `Code a` (`MapF` is defined in
> > >  > | package `parameterized-utils` on hackage).
> > >  > |
> > >  > | Making typed TH work with `Code` directly avoids the need to
> > >  > | constantly switch between `Code` and `Q (TExp a)` and with the new
> > >  > | system users of typed TH are not likely to deal with the latter much
> > >  > | at all.
> > >  > |
> > >  > | For these reasons I recommend that we accept this proposal. Please
> > >  > | let me know if you think otherwise.
> > >  > |
> > >  > | -Iavor
> > >  > | _______________________________________________
> > >  > | ghc-steering-committee mailing list
> > >  > | ghc-steering-committee at haskell.org
> > >  > | https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmail.has
> > >  > | kell.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc-steering-
> > >  > | committee&data=02%7C01%7Csimonpj%40microsoft.com%7Ce2fd3cfd09334b865fb
> > >  > | 308d7620f5a8c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637085690437517
> > >  > | 136&sdata=Qug9nwlVpQIY2U6jw%2FXKOnPpNPfiG6EAfWgv%2BTOJ4e0%3D&reser
> > >  > | ved=0
> > >  > _______________________________________________
> > >  > ghc-steering-committee mailing list
> > >  > ghc-steering-committee at haskell.org
> > >  > https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
> > >
> > >  _______________________________________________
> > >  ghc-steering-committee mailing list
> > > ghc-steering-committee at haskell.org
> > > https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
> > _______________________________________________
> > ghc-steering-committee mailing list
> > ghc-steering-committee at haskell.org
> > https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
> >
> _______________________________________________
> ghc-steering-committee mailing list
> ghc-steering-committee at haskell.org
> https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee