ettiquette for changing an MR under review?

Simon Peyton Jones simon.peytonjones at gmail.com
Tue Feb 8 22:54:07 UTC 2022


I'd just make the changes, and push as a new patch.  Once everything has
settled down, you can compress all the patches into one and force push.

Simon

On Tue, 8 Feb 2022 at 20:44, Norman Ramsey <nr at cs.tufts.edu> wrote:

> I have an MR currently under review.  Review has already identified a
> change I need to make, and I have made it in my local repository.
> Do I push the change now, or do I wait for a more complete review?
> And if I push it now, do I force-push or do I push the changes as a
> separate commit?
>
>
> Norman
> _______________________________________________
> ghc-devs mailing list
> ghc-devs at haskell.org
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-devs/attachments/20220208/cfc54cbb/attachment.html>


More information about the ghc-devs mailing list