Old build system broken

[John Cotton Ericson]

Yeah so what I did is making settings no longer be created directly by 
configure, but by make and hadrian. I did this because I'm moving 
configurations options from Config.hs to there, Config.hs was generated 
by make and hadrian, and the whole thing will become stage-specific.

I tried do mimic what hadrian/make for `Config.hs` and the various 
header files like `ghcplatform.h`, but evidently I missed how those are 
invalidated / cleaned up (unless they change so infrequently that 
cleaning up never worked).

I'm happy to make the fix (especially as I hope to change `settings` 
some more), but I would appreciate some advise from people in the know 
about how the cleaning ought to work. I suspect the cleaning with both 
build systems is broken.

Sorry for the disruption,

John

On 5/8/19 4:33 PM, Richard Eisenberg wrote:
> Some discussion on IRC with @Ericson2314 reveals that make maintainer-clean is not deleting settings files, which cause this bug. If you do a fresh checkout and build, the problem should go away. It's also possible that deleting inplace/lib/settings manually (and then running ./configure) may also fix it.
>
> Richard
>
>> On May 8, 2019, at 3:51 PM, Richard Eisenberg <rae at richarde.dev> wrote:
>>
>> Me too. I'm on a Mac. Deepest apologies (because I know this makes me useless), but I don't have the error message any more. It mentioned "Tables next to code" and the settings file, so I'm confident that it's related.
>>
>> Also, reverting 1aad97887747c351727ebd7b85217f2666f5b835 fixed the problem for me.
>>
>> Richard
>>
>>> On May 8, 2019, at 3:48 PM, Karel Gardas <karel.gardas at centrum.cz> wrote:
>>>
>>>
>>> Sorry to hijack the thread, I get something very similar on ppc64le linux:
>>>
>>> Configuring ghc-prim-0.6.1...
>>> ghc-cabal: '/tmpram/ghc/inplace/bin/ghc-stage1' exited with an error:
>>> No entry for "Tables next to code" in "/tmpram/ghc/inplace/lib/settings"
>>>
>>> libraries/ghc-prim/ghc.mk:4: recipe for target 'libraries/ghc-prim/dist-install/package-data.mk' failed
>>> make[1]: *** [libraries/ghc-prim/dist-install/package-data.mk] Error 1
>>> Makefile:123: recipe for target 'all' failed
>>> make: *** [all] Error 2
>>>
>>> this is from today's HEAD.
>>>
>>> Thanks,
>>> Karel
>>>
>>> On 05/ 8/19 09:28 PM, Phyx wrote:
>>>> That looks like stage1 has been improperly configured.
>>>>
>>>> Does /home/simonpj/code/HEAD/inplace/bin/ghc-stage1 --info
>>>> *
>>>> *
>>>> *Return anything sensible for target arch? *
>>>> *
>>>> *
>>>> *I still use the make system exclusively and haven't noticed a failure. *
>>>> *
>>>> *
>>>> *But my nightlies haven't kicked off yet today. *
>>>> *
>>>> *
>>>> *Thanks, *
>>>> *Tamar
>>>> *
>>>> Sent from my Mobile
>>>>
>>>> On Wed, May 8, 2019, 16:24 Simon Peyton Jones via ghc-devs
>>>> <ghc-devs at haskell.org <mailto:ghc-devs at haskell.org>> wrote:
>>>>
>>>>    I know we are supposed to be using Hadrian now, but is the old build
>>>>    system supposed to be broken? ____
>>>>
>>>>    A clean build fails with____
>>>>
>>>>    "inplace/bin/ghc-cabal" check libraries/ghc-prim____
>>>>
>>>>    "inplace/bin/ghc-cabal" configure libraries/ghc-prim dist-install
>>>>    --with-ghc="/home/simonpj/code/HEAD/inplace/bin/ghc-stage1"
>>>>    --with-ghc-pkg="/home/simonpj/code/HEAD/inplace/bin/ghc-pkg"
>>>>    --disable-library-for-ghci --enable-library-vanilla
>>>>    --enable-library-for-ghci --disable-library-profiling
>>>>    --enable-shared --configure-option=CFLAGS="-Wall
>>>>    -Werror=unused-but-set-variable -Wno-error=inline"
>>>>    --configure-option=LDFLAGS="  " --configure-option=CPPFLAGS="   "
>>>>    --gcc-options="-Wall     -Werror=unused-but-set-variable
>>>>    -Wno-error=inline " --with-gcc="gcc" --with-ld="ld.gold"
>>>>    --with-ar="ar" --with-alex="/usr/bin/alex"
>>>>    --with-happy="/usr/bin/happy"____
>>>>
>>>>    Configuring ghc-prim-0.6.1...____
>>>>
>>>>    ghc-cabal: '/home/simonpj/code/HEAD/inplace/bin/ghc-stage1' exited
>>>>    with an____
>>>>
>>>>    error:____
>>>>
>>>>    Failed to read "target arch" value ""____
>>>>
>>>>    __ __
>>>>
>>>>    libraries/ghc-prim/ghc.mk:4 <http://ghc.mk:4>: recipe for target
>>>>    'libraries/ghc-prim/dist-install/package-data.mk
>>>>    <http://package-data.mk>' failed____
>>>>
>>>>    make[1]: *** [libraries/ghc-prim/dist-install/package-data.mk
>>>>    <http://package-data.mk>] Error 1____
>>>>
>>>>    Makefile:123: recipe for target 'all' failed____
>>>>
>>>>    make: *** [all] Error 2____
>>>>
>>>>    simonpj at MSRC-3645512:~/code/HEAD$____
>>>>
>>>>    _______________________________________________
>>>>    ghc-devs mailing list
>>>>    ghc-devs at haskell.org <mailto:ghc-devs at haskell.org>
>>>>    http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> ghc-devs mailing list
>>>> ghc-devs at haskell.org
>>>> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
>>>>
>>> _______________________________________________
>>> ghc-devs mailing list
>>> ghc-devs at haskell.org
>>> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
>> _______________________________________________
>> ghc-devs mailing list
>> ghc-devs at haskell.org
>> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs