Bug in "changes" tab in Gitlab
Ömer Sinan Ağacan
omeragacan at gmail.com
Wed Jan 16 07:01:10 UTC 2019
Hi,
I think there's a currently a bug in "changes" tab in gitlab. If you look at [1]
it shows as if I added a new line in `Main.hs`, but actually I just changed one
word:
diff --git a/utils/genapply/Main.hs b/utils/genapply/Main.hs
index 71b84fde79..7038dc5c09 100644
--- a/utils/genapply/Main.hs
+++ b/utils/genapply/Main.hs
@@ -903,7 +903,7 @@ genStackApply regstatus args =
--
-- These code fragments are used to save registers on the stack at a heap
-- check failure in the entry code for a function. We also have to save R1
--- and the return address (stg_gc_fun_info) on the stack. See
stg_gc_fun_gen
+-- and the return address (stg_gc_fun_info) on the stack. See __stg_gc_fun
-- in HeapStackCheck.cmm for more details.
I'm guessing that Gitlab is confused by the `---` prefix in the diff.
I was going to report it but I realized that we're not using the latest version
(the "help" page says "update asap"), so perhaps we should try updating first?
[1]: https://gitlab.haskell.org/ghc/ghc/merge_requests/125/diffs?view=parallel
Ömer
More information about the ghc-devs
mailing list