Reviews

[Ben Gamari]

Evan Laforge <qdunkan at gmail.com> writes:

> On Tue, Jan 8, 2019 at 8:54 PM Simon Peyton Jones <simonpj at microsoft.com> wrote:
>> |  > When submitting a review, I often want to add an overall comment, not
>> |  related to  a particular line of code?  How do I do that?
>> |
>> |  I do that by going back to the "Discussion" tab and adding something at the
>> |  bottom.
>>
>> But alas then it does not form part of the review, landing as a single email. It becomes a separate, disconnected comment.
>
> As far as I can tell, Gitlab doesn't really have a concept of a
> review, it's just big pile of disconnected comments... or rather,
> they're just all connected to the MR.


This isn't quite true. Transactional reviews were added in GitLab 11.4
[1]. That being said, the connection between the comments in a review is
a bit looser than it was in Phabricator.


Cheers,

- Ben

[1] https://gitlab.com/gitlab-org/gitlab-ee/issues/1984
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 487 bytes
Desc: not available
URL: <http://mail.haskell.org/pipermail/ghc-devs/attachments/20190110/46d09525/attachment.sig>