Reviews

Evan Laforge qdunkan at gmail.com
Tue Jan 8 12:48:00 UTC 2019


On Tue, Jan 8, 2019 at 6:01 PM Simon Peyton Jones via ghc-devs
<ghc-devs at haskell.org> wrote:
>
> When reviewing a MR, I sometimes want to look at (and even add comments to) code that isn’t displayed in the MR window.  With Phab there was a “show 20 more lines” link, and even “show the whole file”.  How do I do that in GitLab?

If you click on the gray-ish text on the top and bottom edges of the
displayed greed/red diff areas, it should give you some more lines.

> When submitting a review, I often want to add an overall comment, not related to  a particular line of code?  How do I do that?

I do that by going back to the "Discussion" tab and adding something
at the bottom.


More information about the ghc-devs mailing list