Glasgow Haskell Compiler | Fix #16133 by checking for TypeApplications in rnExpr (!77)

Simon Peyton Jones simonpj at microsoft.com
Sun Jan 6 21:19:24 UTC 2019


I am now getting lots of email from GitLab, and I’m trying to figure out what they all mean.  They come in various forms.

Here’s one puzzler:

  *   what does the email below mean?  Is it a new merge request?
  *   what is the “!77”?
  *   What does “RyanGlScott/ghc:wip/T16133 → ghc/ghc:master” mean?

Simon

From: Ryan Scott <gitlab at gitlab.haskell.org>
Sent: 05 January 2019 17:46
To: Simon Peyton Jones <simonpj at microsoft.com>
Subject: Glasgow Haskell Compiler | Fix #16133 by checking for TypeApplications in rnExpr (!77)


Project:Branches: RyanGlScott/ghc:wip/T16133 → ghc/ghc:master

We had a validity check, typeAppErr, for visible kind applications (in rnHsTyKi), but didn't extend the same treatment to visible type applications (in rnExpr). Easily fixed by also invoking typeAppErr from rnExpr.

Fixes https://ghc.haskell.org/trac/ghc/ticket/16133<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fghc.haskell.org%2Ftrac%2Fghc%2Fticket%2F16133&data=02%7C01%7Csimonpj%40microsoft.com%7Cbf82903cc44a4d36b9fc08d673359a05%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636823071390233674&sdata=1C1YifOb243Ttrz97KqtnAEr9yH0R17qZr0yh%2FgKKRU%3D&reserved=0>.

—
View it on GitLab<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.haskell.org%2Fghc%2Fghc%2Fmerge_requests%2F77&data=02%7C01%7Csimonpj%40microsoft.com%7Cbf82903cc44a4d36b9fc08d673359a05%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636823071390243688&sdata=bQpVrLN6RrQh%2FsjS026e8uGB%2FRfczQJjU0mYrEkOeU8%3D&reserved=0>.
You're receiving this email because of your account on gitlab.haskell.org. If you'd like to receive fewer emails, you can unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.haskell.org%2Fsent_notifications%2F447feb65a22c202ff644b44f5138d312%2Funsubscribe&data=02%7C01%7Csimonpj%40microsoft.com%7Cbf82903cc44a4d36b9fc08d673359a05%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636823071390243688&sdata=xxqzuYyyI4VS%2FsSZ0U10VaYMu9865gAEHDno72uJffw%3D&reserved=0> from this thread or adjust your notification settings.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-devs/attachments/20190106/78daa554/attachment.html>


More information about the ghc-devs mailing list