GitLab: Cmd+Enter considered harmful on reviews

Richard Eisenberg rae at
Fri Jan 4 18:12:37 UTC 2019

I'm on Firefox.

It doesn't matter all that much, really. I was hoping that a review was its own thing. But GitLab doesn't do that: a review is just a set of comments all delivered at the same time. Now that I've posted my review, my comments have become 49 separate "discussions". Oof.


> On Jan 4, 2019, at 1:09 PM, Ben Gamari <ben at> wrote:
> Richard Eisenberg <rae at> writes:
>> PSA: When reviewing an MR on GitLab, every comment has two buttons:
>> (1) add to review, and (2) add comment now. Cmd+Enter (on my machine
>> at least), does option (2), even though option (1) is bold and green.
>> This is not what I wanted. (By the way, "comments" actually open these
>> things called "discussions", which can be resolved. But that's another
>> matter.)
> Hmm, strange. I can't seem to reproduce this. Which browser are you
> using?
> Cheers,
> - Ben

More information about the ghc-devs mailing list