Marge has been stabilised

Simon Peyton Jones simonpj at microsoft.com
Wed Feb 13 16:03:21 UTC 2019


|  As far as I can work out the WIP field is a part of the semantic model
|  but the only way it displays on the UI is in the title.

If you want to change the status using the UI (not via a "quick action") do you literally edit the title?  That is, the semantics is driven from the title string itself?  Or do you do something else in the UI?

S

|  -----Original Message-----
|  From: Matthew Pickering <matthewtpickering at gmail.com>
|  Sent: 13 February 2019 10:10
|  To: Simon Peyton Jones <simonpj at microsoft.com>
|  Cc: Richard Eisenberg <rae at cs.brynmawr.edu>; GHC developers <ghc-
|  devs at haskell.org>
|  Subject: Re: Marge has been stabilised
|  
|  As far as I can work out the WIP field is a part of the semantic model
|  but the only way it displays on the UI is in the title.
|  
|  Two other facets of the WIP state are:
|  
|  1. WIP MRs can't be merged via the UI. (Marge also honours this) 2. The
|  list of MRs can be filtered by the WIP status (which is that I use it
|  for).
|  
|  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.gi
|  tlab.com%2Fee%2Fuser%2Fproject%2Fmerge_requests%2Fwork_in_progress_merge_
|  requests.html&data=02%7C01%7Csimonpj%40microsoft.com%7C9936c5095e3147
|  63f30008d6919b61a2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636856493
|  881824887&sdata=ii1%2FHl0V94%2F8BssWQr%2F43dSOALvm0QFw7VIGeoFIar0%3D&
|  amp;reserved=0
|  
|  Your page is very helpful Simon. If you have any more questions then I'll
|  try to answer.
|  
|  Cheers,
|  
|  Matt
|  
|  On Wed, Feb 13, 2019 at 9:38 AM Simon Peyton Jones
|  <simonpj at microsoft.com> wrote:
|  >
|  > Interesting.  That page says (my emphasis)
|  >
|  >
|  >
|  > Quick actions are textual shortcuts for common actions on issues,
|  epics, merge requests, and commits that are usually done by clicking
|  buttons or dropdowns in GitLab’s UI. You can enter these commands while
|  creating a new issue or merge request, or in comments of issues, epics,
|  merge requests, and commits. Each command should be on a separate line in
|  order to be properly detected and executed. Once executed, the commands
|  are removed from the text body and not visible to anyone else.
|  >
|  >
|  >
|  > So this may be a useful shortcut, but it’s optional.
|  >
|  >
|  >
|  > So that means that this “WIP” thing is part of GitLab’s semantic
|  > model.  The table says
|  >
|  >
|  >
|  > /wip: Toggle the Work In Progress status
|  >
|  >
|  >
|  > So it seems that
|  >
|  > Each MR has a WIP status
|  > There is some way in the UI to toggle it
|  >
|  >
|  >
|  > Do you know what are the semantics of “WIP status”?  It’s not just the
|  title!
|  >
|  >
|  >
|  > I assume it is /not/ “WIP MRs aren’t merged” because no MR is merged
|  until there are enough approvals /and/ the author clicks “please merge”.
|  Correct?
|  >
|  >
|  >
|  > Sorry to be dim.  I’m a bit slow to catch up with GitLab.
|  >
|  >
|  >
|  > I have a “Simon’s GitLab page” here
|  > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fghc.
|  > haskell.org%2Ftrac%2Fghc%2Fwiki%2FWorkingConventions%2FGitLabSPJ&d
|  > ata=02%7C01%7Csimonpj%40microsoft.com%7C9936c5095e314763f30008d6919b61
|  > a2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636856493881824887&amp
|  > ;sdata=0%2BFu2xOOc1SqVx4mwmmEf7pGX3CUfENIvjFf7MPINhs%3D&reserved=0
|  >
|  >
|  >
|  > I use it to add notes on things I’ve learned.
|  >
|  >
|  >
|  > Simon
|  >
|  >
|  >
|  >
|  >
|  > | -----Original Message-----
|  >
|  > | From: ghc-devs <ghc-devs-bounces at haskell.org> On Behalf Of Matthew
|  >
|  > | Pickering
|  >
|  > | Sent: 12 February 2019 16:29
|  >
|  > | To: Richard Eisenberg <rae at cs.brynmawr.edu>
|  >
|  > | Cc: GHC developers <ghc-devs at haskell.org>
|  >
|  > | Subject: Re: Marge has been stabilised
|  >
|  > |
|  >
|  > | Yes there are two others I use frequently.
|  >
|  > |
|  >
|  > | /approve - Approves a Merge request
|  >
|  > | /assign - Assign a user
|  >
|  > |
|  >
|  > | and I imagine I will use /label and /relabel frequently when we have
|  >
|  > | labels.
|  >
|  > |
|  >
|  > | It's also useful to know that the ! autocomplete for merge requests
|  >
|  > | can be filtered by name of MR. The user autocomplete @ can also be
|  >
|  > | filtered by a user's real name.
|  >
|  > |
|  >
|  > | There is a full list here:
|  >
|  > | https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdo
|  > | cs.gitl
|  >
|  > | ab.com%2Fee%2Fuser%2Fproject%2Fquick_actions.html&data=02%7C01%7
|  > | Csimonp
|  >
|  > | j%40microsoft.com%7Cb91996c8302240d8c75c08d691074201%7C72f988bf86f14
|  > | 1af91ab
|  >
|  > | 2d7cd011db47%7C1%7C0%7C636855857693042801&sdata=ngK1tGiNd6ZLGMS3
|  > | 4emZYv%
|  >
|  > | 2B31dHS1nfUQ9StRSLXwcQ%3D&reserved=0
|  >
|  > |
|  >
|  > | Cheers,
|  >
|  > |
|  >
|  > | Matt
|  >
|  > |
|  >
|  > | On Tue, Feb 12, 2019 at 4:23 PM Richard Eisenberg
|  > | <rae at cs.brynmawr.edu>
|  >
|  > | wrote:
|  >
|  > | >
|  >
|  > | >
|  >
|  > | >
|  >
|  > | > On Feb 12, 2019, at 10:51 AM, Matthew Pickering
|  >
|  > | <matthewtpickering at gmail.com> wrote:
|  >
|  > | >
|  >
|  > | > This can be quickly toggled on/off by typing the /wip quick
|  > | > command in
|  >
|  > | > a comment.
|  >
|  > | >
|  >
|  > | >
|  >
|  > | > This is an interesting aside. I understand this to mean: If I make
|  > | > a
|  >
|  > | comment (the same place that I would write a comment for humans)
|  > | that
|  >
|  > | consists solely of "/wip", then instead of posting anything to
|  > | humans, the
|  >
|  > | title of my MR changes, either adding "WIP: " or deleting that from
|  > | the
|  >
|  > | beginning.
|  >
|  > | >
|  >
|  > | > Are there other such pieces of magic? Is there a place they are
|  listed?
|  >
|  > | >
|  >
|  > | > Thanks!
|  >
|  > | > Richard
|  >
|  > | _______________________________________________
|  >
|  > | ghc-devs mailing list
|  >
|  > | ghc-devs at haskell.org
|  >
|  > | https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmai
|  > | l.haske
|  >
|  > | ll.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc-
|  >
|  > | devs&data=02%7C01%7Csimonpj%40microsoft.com%7Cb91996c8302240d8c7
|  > | 5c08d69
|  >
|  > | 1074201%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636855857693042
|  > | 801&amp
|  >
|  > | ;sdata=ciA051iOt74WyZMrr9HulHik%2BG4la8YyF47sYnbqvzs%3D&reserved
|  > | =0


More information about the ghc-devs mailing list