Validate on master broken.

[Ömer Sinan Ağacan]

This was also reported as #15900.

Ömer

Simon Peyton Jones via ghc-devs <ghc-devs at haskell.org>, 16 Kas 2018
Cum, 02:33 tarihinde şunu yazdı:
>
> Bother -- my fault.  Sorry about that.  I should have
> thought of Haddock.
>
> Thanks for fixing.
>
> Simon
>
> | -----Original Message-----
> | From: ghc-devs <ghc-devs-bounces at haskell.org> On Behalf Of Alec Theriault
> | Sent: 15 November 2018 21:41
> | To: Andreas Klebinger <klebinger.andreas at gmx.at>
> | Cc: ghc-devs at haskell.org
> | Subject: Re: Validate on master broken.
> |
> | Thanks for noticing!
> |
> | I’m fixing this right now. The changes needed are really quite mundane…
> |
> | -Alec
> |
> | > On Nov 15, 2018, at 1:28 PM, Andreas Klebinger
> | <klebinger.andreas at gmx.at> wrote:
> | >
> | > Hello Devs,
> | >
> | > it seems Simons patch "Smarter HsType pretty-print for promoted
> | datacons" broke ./validate.
> | >
> | >
> | >
> | >> I discovered that there were two copies of the PromotionFlag
> | >>    type (a boolean, with helpfully named data cons), one in
> | >>    IfaceType and one in HsType.  So I combined into one,
> | >>    PromotionFlag, and moved it to BasicTypes.
> | >
> | > In particular haddock seems to have depended on the changed
> | constructors.
> | > If anyone with access and knowledge of haddock could fix  this I would
> | be grateful.
> | >
> | >
> | > Cheers
> | > Andreas
> | > _______________________________________________
> | > ghc-devs mailing list
> | > ghc-devs at haskell.org
> | >
> | https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.haske
> | ll.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc-
> | devs&data=02%7C01%7Csimonpj%40microsoft.com%7Cd72f4aad7f794904722108d6
> | 4b43130f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C1%7C636779148787876537&a
> | mp;sdata=rdOrnWF4V6hUy%2FHm9UYaEowR2T8ND0DXuCj15rPY0CY%3D&reserved=0
> |
> | _______________________________________________
> | ghc-devs mailing list
> | ghc-devs at haskell.org
> | https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.haske
> | ll.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc-
> | devs&data=02%7C01%7Csimonpj%40microsoft.com%7Cd72f4aad7f794904722108d6
> | 4b43130f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C1%7C636779148787876537&a
> | mp;sdata=rdOrnWF4V6hUy%2FHm9UYaEowR2T8ND0DXuCj15rPY0CY%3D&reserved=0
> _______________________________________________
> ghc-devs mailing list
> ghc-devs at haskell.org
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs