collectBindersPushingCo

Simon Peyton Jones simonpj at microsoft.com
Wed Mar 1 08:17:05 UTC 2017


David
Thanks for moving my early-inline patch series to HEAD.
You'll remember that I pushed this patch (below) to spj-early-inline2
Can you be sure to cherry-pick this one too?  It's important and I don't see it in HEAD yet.  I'm surprised that there isn't a validate failure (T9505 if memory serves - see attached).
Simon


commit 002192aa8df463ae945e8a94147cfc1d848f43a5

Author: Simon Peyton Jones <simonpj at microsoft.com>

Date:   Fri Feb 24 16:55:36 2017 +0000



    Fix a nasty bug in CoreSubst.collectBindersPushingCo



    The bug wsa in the use of (mkNthCo 0) to get the argument

    part of a function coercion.  Not so! Now (->) takes four

    arguments so that 0 should have been 2.



    Enough with magic numbers. I defined decomposeFunCo, and used

    it throughout.  Much nicer now; and correct.



    The nete effect, incidentally, was that T9509 was failing to

    specialise.  (And that was the initial reason for introducing

    collectBindersPushingCo in the first place.)

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-devs/attachments/20170301/cdf1a6cf/attachment-0001.html>
-------------- next part --------------
An embedded message was scrubbed...
From: Simon Peyton Jones <simonpj at microsoft.com>
Subject: RE: Progress on early inline
Date: Fri, 24 Feb 2017 16:59:25 +0000
Size: 18511
URL: <http://mail.haskell.org/pipermail/ghc-devs/attachments/20170301/cdf1a6cf/attachment-0001.mht>


More information about the ghc-devs mailing list