Phab failing to apply patches
thomasmiedema at gmail.com
Mon Jan 18 16:44:46 UTC 2016
On Sun, Jan 17, 2016 at 4:24 PM, Jan Stolarek <jan.stolarek at p.lodz.pl>
> Can we somehow force Phab to apply a patch against a base commit from
> which the patch was created?
I don't know about "somehow", maybe Austin knows a way.
The current default should not be changed though, in my opinion. We expect
contributors to make their patches against HEAD, and we want to review them
against HEAD. So Harbormaster should also try to build them against HEAD.
If you are working from an old base commit, either rebase your patch before
submitting to Phabricator (painful? you will have to do it before pushing
anyway, might as well do it now), or ignore the Harbormaster validate
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the ghc-devs