Phab not running a full validate?
thomasmiedema at gmail.com
Tue Jan 12 08:57:44 UTC 2016
The top window (remote - stderr) is the result of a normal `./validate`,
with some output suppressed.
The bottom window (remote - stdout) is the result of rerunning any failing
Note that Phabricator does indeed *not* run a full validate on patches or
commits (i.e. it does not run `./validate --slow`), because it would take
too long (Harbormaster is already having problems with the current load it
gets), and would only sporadically catch a bug that `./validate (--normal)`
would not have caught. When you add a new test yourself, and you want to be
sure it also passes `validate --slow`, please run that test locally using
`make TEST=<testname> slow` in the testsuite directory.
The different speed settings of the testsuite are explained on
and in `Note [validate and testsuite speed]` in the toplevel Makefile.
On Tue, Jan 12, 2016 at 2:06 AM, Matthew Pickering <
matthewtpickering at gmail.com> wrote:
> I think it does run them all. If you look at the full stdout log it runs
> the failing tests again after finishing the run.
> On 12 Jan 2016 00:59, "Richard Eisenberg" <eir at cis.upenn.edu> wrote:
>> Hi devs,
>> Take a look at https://phabricator.haskell.org/harbormaster/build/9990/
>> See how only 1 test was run. Is this expected? Does Phab now bail when it
>> runs into an error? Or have I done something wrong?
>> ghc-devs mailing list
>> ghc-devs at haskell.org
> ghc-devs mailing list
> ghc-devs at haskell.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the ghc-devs