D1182: Implement improved error messages for ambiguous type variables (#10733)

Simon Marlow marlowsd at gmail.com
Thu Sep 3 19:02:58 UTC 2015


On 03/09/2015 09:08, Simon Peyton Jones wrote:
> Edward
>
> | Jan's injective type families commit is causing tcfail220 to fail, but
> | that's unrelated to this ticket.
>
> This is true.  I told Jan to commit anyway because tcfail220 is a "hsig" test, and
>   a) I know that hsigs are in flux (although I am not clear about how)
>   b) I don't understand them enough to fix.
>
> So I hope it's ok to have broken this.  Jan and I can certainly help when you want to fix it.

In general we shouldn't commit anything that breaks validate, because 
this causes problems for other developers.  The right thing to do would 
be to mark it expect_broken before committing.

Cheers
Simon


>
> Meanwhile would you mark it as expect-broken.  (Although I am not sure that it's worth opening a fresh ticket for it.)
>
> thanks
>
> Simon
>
>
> | -----Original Message-----
> | From: noreply at phabricator.haskell.org
> | [mailto:noreply at phabricator.haskell.org]
> | Sent: 03 September 2015 07:11
> | To: Simon Peyton Jones
> | Subject: [Differential] [Commented On] D1182: Implement improved error
> | messages for ambiguous type variables (#10733)
> |
> | KaneTW added a comment.
> |
> | Jan's injective type families commit is causing tcfail220 to fail, but
> | that's unrelated to this ticket.
> |
> |
> | REPOSITORY
> |   rGHC Glasgow Haskell Compiler
> |
> | REVISION DETAIL
> |   https://phabricator.haskell.org/D1182
> |
> | EMAIL PREFERENCES
> |   https://phabricator.haskell.org/settings/panel/emailpreferences/
> |
> | To: KaneTW, simonpj, bgamari, austin
> | Cc: goldfire, simonpj, thomie
> _______________________________________________
> ghc-devs mailing list
> ghc-devs at haskell.org
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
>


More information about the ghc-devs mailing list