[commit: ghc] master: Remove PatSynBuilderId (2208011)

Ben Gamari ben at well-typed.com
Tue Nov 17 16:40:58 UTC 2015

Simon Peyton Jones <simonpj at microsoft.com> writes:

> |  I don't think this would work in the case where there are no fields
> |  initialised?
> Oh yes, silly me. I was thinking that then we wouldn’t need to look at
> 'labels' at all, but that's not true.
> Well, at least then I'd replace [PostTc id [FieldLabel] with (PostTc
> ConLike). This makes it like ConPatOut in HsPat. Then the (Located id)
> field is redundant (we can get it from the ConLike), but that’s only
> true after typechecking, so maybe simpler to keep both.
> It amounts to moving the call to conLikeFieldLabels from tcExpr
> (RecordCon ...) to dsExpr (RecordCon ...). A small thing but I think
> it'd be better.
Mathew, did you ever get to this?


- Ben
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 472 bytes
Desc: not available
URL: <http://mail.haskell.org/pipermail/ghc-devs/attachments/20151117/6ee15d99/attachment.sig>

More information about the ghc-devs mailing list