too many lines too long
eir at cis.upenn.edu
Tue Nov 17 14:15:57 UTC 2015
We have such a thing: https://ghc.haskell.org/trac/ghc/wiki/Commentary/CodingStyle
I don't think its widely consulted or respected, though.
On Nov 17, 2015, at 5:19 AM, Simon Marlow <marlowsd at gmail.com> wrote:
> On 13/11/2015 15:01, Jan Stolarek wrote:
>> My view on this is:
>> Firstly, I hate explaining myself to Arcanist. When prompted to explain the reason for too long
>> lines I typically enter "wontfix" without thinking too much.
>> Secondly, I really don't like how warnings clutter code reviews.
>> I have my Emacs highlight text beyond 80th column with a really ugly colour, so I strive real hard
>> to maintain 80-column limit whenever possible. But sometimes fitting in that limit is nearly
>> impossible: imagine being in a let nested in a do-notation nested in a guard nested in a where
>> clause. Approx. 15-20 columns are lost for the indentation. Nevertheless I would support
>> introducing a hard limit on having no more than 80 columns.
>> PS. It makes me really sad that we don't have any coding convention for GHC: we mix camelCase with
>> underscore_case, indentation is inconsistent (good thing we at least got rid of tabs!),
>> whitespace usage is inconsistent, etc. I could make this list very long.
> Why not write down a set of style guidelines and get everyone to agree to them? I'd happily compromise my personal stylistic preferences if there was a standard style that we all agreed on and tried to adhere to.
> Personally I think a good starting point is http://chrisdone.github.io/hindent/HIndent-Styles-JohanTibell.html
> Incidentally the mixed camelCase and underscore style is deliberate: underscores for local identifiers, camelCase for exported functions. It's a cute idea I've been using for a long time, but we don't have to do it that way. At work we use camelCase exclusively and it's fine.
>> Politechnika ÅÃ³dzka
>> Lodz University of Technology
>> TreÅ›Ä‡ tej wiadomoÅ›ci zawiera informacje przeznaczone tylko dla adresata.
>> JeÅ¼eli nie jesteÅ›cie PaÅ„stwo jej adresatem, bÄ…dÅº otrzymaliÅ›cie jÄ… przez pomyÅ‚kÄ™
>> prosimy o powiadomienie o tym nadawcy oraz trwaÅ‚e jej usuniÄ™cie.
>> This email contains information intended solely for the use of the individual to whom it is addressed.
>> If you are not the intended recipient or if you have received this message in error,
>> please notify the sender and delete it from your system.
>> ghc-devs mailing list
>> ghc-devs at haskell.org
> ghc-devs mailing list
> ghc-devs at haskell.org
More information about the ghc-devs