GitHub pull requests
Edward Z. Yang
ezyang at mit.edu
Mon Oct 6 16:01:06 UTC 2014
To be completely clear, arc does not FORCE you to squash commits.
You can simply arc diff each commit in question seperately.
Now, it is certainly true that arc does not make this easy to do.
Excerpts from Andreas Abel's message of 2014-10-06 03:27:10 -0600:
> This is also the thing that worries most about arc: Squashing commits.
> Splitting commits into
> * things that only do whitespace changes
> * things that only add comments
> * things that only refactor
> * things that actually introduce a semantic change
> *is* very valuable also for the efficency of the review process.
> On 05.10.2014 19:13, Tuncer Ayaz wrote:
> > On Sun, Oct 5, 2014 at 4:32 PM, Ben Gamari wrote:
> >> 5.a. I reflected on the mild shock of seeing that `arc` had squashed my
> >> carefully crafted patch set into a single commit. This still
> >> bothers me to this day.
> > I second 5.a, but does it have to be this way, or can arc be
> > instructed to not squash commits?
More information about the ghc-devs