GitHub pull requests
Andreas Abel
abela at chalmers.se
Mon Oct 6 09:27:10 UTC 2014
This is also the thing that worries most about arc: Squashing commits.
Splitting commits into
* things that only do whitespace changes
* things that only add comments
* things that only refactor
* things that actually introduce a semantic change
*is* very valuable also for the efficency of the review process.
On 05.10.2014 19:13, Tuncer Ayaz wrote:
> On Sun, Oct 5, 2014 at 4:32 PM, Ben Gamari wrote:
>> 5.a. I reflected on the mild shock of seeing that `arc` had squashed my
>> carefully crafted patch set into a single commit. This still
>> bothers me to this day.
>
> I second 5.a, but does it have to be this way, or can arc be
> instructed to not squash commits?
--
Andreas Abel <>< Du bist der geliebte Mensch.
Department of Computer Science and Engineering
Chalmers and Gothenburg University, Sweden
andreas.abel at gu.se
http://www2.tcs.ifi.lmu.de/~abel/
More information about the ghc-devs
mailing list