[commit: ghc] master: compiler: fix trac issue #8815 (780b061)

[Joachim Breitner]

Hi,

just a quick note:

This commit message is rather unhelpful. In this case it is not a big
deal (the patch is quite self-explanatory), but I recommend you to
manually clean up arc-generated commit messages before pushing.

Also remember when creating a Phab DR that whatever you put in the
summary will be part of the default commit message.

Greetings,
Joachim
(who does more complaining than actual contributing these days...)

Am Sonntag, den 30.11.2014, 19:17 +0000 schrieb git at git.haskell.org:
> Repository : ssh://git@git.haskell.org/ghc
> 
> On branch  : master
> Link       : http://ghc.haskell.org/trac/ghc/changeset/780b061ce2aea4722d1a5d0e46fd4ed8ee2641d6/ghc
> 
> >---------------------------------------------------------------
> 
> commit 780b061ce2aea4722d1a5d0e46fd4ed8ee2641d6
> Author: Sivaram Balakrishnan <sivaram1992 at gmail.com>
> Date:   Sun Nov 30 13:05:56 2014 -0600
> 
>     compiler: fix trac issue #8815
>     
>     Summary: This patch changes the error message as suggested in trac issue #8815 comments.
>     
>     Reviewers: jstolarek, austin
>     
>     Reviewed By: jstolarek, austin
>     
>     Subscribers: jstolarek, thomie, carter
>     
>     Differential Revision: https://phabricator.haskell.org/D533
>     
>     GHC Trac Issues: #8815
> 
> 
> >---------------------------------------------------------------
> 
> 780b061ce2aea4722d1a5d0e46fd4ed8ee2641d6
>  compiler/typecheck/TcPat.lhs | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/compiler/typecheck/TcPat.lhs b/compiler/typecheck/TcPat.lhs
> index 3b7b5df..58e8bae 100644
> --- a/compiler/typecheck/TcPat.lhs
> +++ b/compiler/typecheck/TcPat.lhs
> @@ -796,7 +796,8 @@ tcDataConPat penv (L con_span con_name) data_con pat_ty arg_pats thing_inside
>          ; gadts_on    <- xoptM Opt_GADTs
>          ; families_on <- xoptM Opt_TypeFamilies
>          ; checkTc (no_equalities || gadts_on || families_on)
> -                  (ptext (sLit "A pattern match on a GADT requires GADTs or TypeFamilies"))
> +                  (text "A pattern match on a GADT requires the" <+>
> +                   text "GADTs or TypeFamilies language extension")
>                    -- Trac #2905 decided that a *pattern-match* of a GADT
>                    -- should require the GADT language flag.
>                    -- Re TypeFamilies see also #7156
> 
> _______________________________________________
> ghc-commits mailing list
> ghc-commits at haskell.org
> http://www.haskell.org/mailman/listinfo/ghc-commits
> 

-- 
Joachim “nomeata” Breitner
  mail at joachim-breitner.de • http://www.joachim-breitner.de/
  Jabber: nomeata at joachim-breitner.de  • GPG-Key: 0xF0FBF51F
  Debian Developer: nomeata at debian.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://www.haskell.org/pipermail/ghc-devs/attachments/20141130/1e92a3df/attachment.sig>