How to fix T5979?

Joachim Breitner mail at joachim-breitner.de
Sat May 10 09:42:33 UTC 2014


Hi,

SPJ recently committed:

        commit 12332f1add3eb9615a62abb36898819b2e67e865
        Author: Simon Peyton Jones <simonpj at microsoft.com>
        Date:   Thu May 8 13:06:05 2014 +0100
        
            Error message wibble, presumably due to recent changes in transformers
        
        diff --git a/testsuite/tests/ghci/scripts/T5979.stderr b/testsuite/tests/ghci/scripts/T5979.stderr
        index fe6e012..7230011 100644
        --- a/testsuite/tests/ghci/scripts/T5979.stderr
        +++ b/testsuite/tests/ghci/scripts/T5979.stderr
        @@ -1,4 +1,4 @@
         
         <no location info>:
             Could not find module ‘Control.Monad.Trans.State’
        -    It is not a module in the current program, or in any known package.
        +    It is a member of the hidden package ‘transformers-0.3.0.0’.
        
But that breaks when transformers is indeed not installed (as it is the
case in a minimal validation run such as on travis):


        Actual stderr output differs from expected:
        --- ./ghci/scripts/T5979.stderr	2014-05-10 03:10:07.860423047 +0000
        +++ ./ghci/scripts/T5979.run.stderr	2014-05-10 03:32:54.861642002 +0000
        @@ -1,4 +1,4 @@
         
         <no location info>:
             Could not find module ‘Control.Monad.Trans.State’
        -    It is a member of the hidden package ‘transformers-0.3.0.0’.
        +    It is not a module in the current program, or in any known package.
        *** unexpected failure for T5979(ghci)


For now I added a reqlib('transformers') to the test, hoping that that
helps. But why should the error message mention "transformers" at all
when the package import is actually explicit to import "nonexisting"?

        $ cat T5979.script 
        :set -XPackageImports
        import "nonexisting" Control.Monad.Trans.State
        import "transformers" Control.Monad.Trans.State
        import "transformers" Control.Monad.Trans.Reader
        
I am a bit worried that there is a regression here and SPJs commit just
hides it. But gotta run now and cannot investigate further.

Greetings,
Joachim



-- 
Joachim “nomeata” Breitner
  mail at joachim-breitner.dehttp://www.joachim-breitner.de/
  Jabber: nomeata at joachim-breitner.de  • GPG-Key: 0xF0FBF51F
  Debian Developer: nomeata at debian.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://www.haskell.org/pipermail/ghc-devs/attachments/20140510/dc882dbc/attachment.sig>


More information about the ghc-devs mailing list