[commit: ghc] master: Remove -fno-warn-amp sledgehammers for validate (6074c5d)

[Austin Seipp]

Yes the first part is done - see 3608f657d5

I removed the validate bandages first, so I could make sure that
everything worked properly with -fno-warn-amp *legitimately* on and
not deprecated. I then removed it afterwords in 3608f657d5 and
replaced it with a deprecation notice. That means HEAD should now be
100% ready to actually make Applicative a superclass of Monad, the
changes require shuffling around a bit of stuff in base though, I
think.

On Mon, Apr 21, 2014 at 2:47 AM, Simon Peyton Jones
<simonpj at microsoft.com> wrote:
> There is much more to change, right?
>
> * The code in the compiler that implements -fwarn-amp
> * Actually making Applicative a superclass of monad
>
> Simon
>
> | -----Original Message-----
> | From: ghc-commits [mailto:ghc-commits-bounces at haskell.org] On Behalf Of
> | git at git.haskell.org
> | Sent: 20 April 2014 07:02
> | To: ghc-commits at haskell.org
> | Subject: [commit: ghc] master: Remove -fno-warn-amp sledgehammers for
> | validate (6074c5d)
> |
> | Repository : ssh://git@git.haskell.org/ghc
> |
> | On branch  : master
> | Link       :
> | http://ghc.haskell.org/trac/ghc/changeset/6074c5da7f48f10e9b3b88d14607e
> | c4955735931/ghc
> |
> | >---------------------------------------------------------------
> |
> | commit 6074c5da7f48f10e9b3b88d14607ec4955735931
> | Author: Austin Seipp <austin at well-typed.com>
> | Date:   Sun Apr 20 01:00:44 2014 -0500
> |
> |     Remove -fno-warn-amp sledgehammers for validate
> |
> |     GHC should now fully compliant with respect to the Applicative
> | Monad
> |     proposal (including all upstream libraries), and does not need to
> |     suppress this warning anymore.
> |
> |     Signed-off-by: Austin Seipp <austin at well-typed.com>
> |
> |
> | >---------------------------------------------------------------
> |
> | 6074c5da7f48f10e9b3b88d14607ec4955735931
> |  mk/validate-settings.mk |    2 --
> |  1 file changed, 2 deletions(-)
> |
> | diff --git a/mk/validate-settings.mk b/mk/validate-settings.mk index
> | 8797bf9..cac938d 100644
> | --- a/mk/validate-settings.mk
> | +++ b/mk/validate-settings.mk
> | @@ -32,7 +32,6 @@ SRC_HC_OPTS     += $(WERROR) -Wall
> |
> |  GhcStage1HcOpts += -fwarn-tabs
> |  GhcStage2HcOpts += -fwarn-tabs
> | -GhcStage2HcOpts += -fno-warn-amp # Temporary sledgehammer until we
> | sync upstream.
> |
> |  utils/hpc_dist-install_EXTRA_HC_OPTS += -fwarn-tabs
> |
> | @@ -46,7 +45,6 @@ GhcStage2HcOpts += -O -dcore-lint  # running of the
> | tests, and faster building of the utils to be installed
> |
> |  GhcLibHcOpts    += -O -dcore-lint
> | -GhcLibHcOpts    += -fno-warn-amp # Temporary sledgehammer until we
> | sync upstream.
> |
> |  # We define DefaultFastGhcLibWays in this style so that the value is
> | # correct even if the user alters DYNAMIC_GHC_PROGRAMS.
> |
> | _______________________________________________
> | ghc-commits mailing list
> | ghc-commits at haskell.org
> | http://www.haskell.org/mailman/listinfo/ghc-commits
> _______________________________________________
> ghc-devs mailing list
> ghc-devs at haskell.org
> http://www.haskell.org/mailman/listinfo/ghc-devs
>



-- 
Regards,

Austin Seipp, Haskell Consultant
Well-Typed LLP, http://www.well-typed.com/