The build is broken (Solaris/x86, FreeBSD/{i386,amd64})

[Edward Z. Yang]

Hey Gergo,

It looks like this failure came from one of your commits, which didn't
include a submodule update.

One trick that I find very useful for making sure that I haven't missed
any files when submitting a patch is to always run 'git status' before I
push, and carefully look at all the output, especially staged but not
committed changes.  I think Simon Marlow is even more conservative, and
does his validate builds in a separate tree so he catches missing files.

Edward

Excerpts from Herbert Valerio Riedel's message of 2014-04-14 00:17:51 -0700:
> Hi,
> 
> (probably) fixed by
> 
>  http://git.haskell.org/ghc.git/commitdiff/b4a820f97e48199a92f5ce7216731500f9a841c9
> 
> 
> 
> On 2014-04-14 at 09:15:42 +0200, Páli Gábor János wrote:
> 
> [...]
> 
> > utils/haddock/src/Haddock/Interface/Create.hs:367:44:
> >     Couldn't match type 'GenLocated SrcSpan (HsBindLR Name Name)'
> >                   with '(a1, Located (HsBind id))'
> >     Expected type: TyClDecl Name -> Bag (a1, Located (HsBind id))
> >       Actual type: TyClDecl Name -> LHsBinds Name
> >     Relevant bindings include
> >       defs :: [Located (HsDecl id)]
> >         (bound at utils/haddock/src/Haddock/Interface/Create.hs:367:5)
> >     In the second argument of '(.)', namely 'tcdMeths'
> >     In the second argument of '(.)', namely 'bagToList . tcdMeths'
> > utils/haddock/src/Haddock/Interface/Create.hs:393:22:
> >     Couldn't match type 'GenLocated SrcSpan (HsBindLR Name Name)'
> >                   with '(a0, Located (HsBind Name))'
> >     Expected type: HsValBindsLR Name Name
> >                    -> [(a0, Located (HsBind Name))]
> >       Actual type: HsValBindsLR Name Name -> [LHsBindLR Name Name]
> >     In the first argument of '(.)', namely 'valbinds'
> >     In the second argument of '(.)', namely 'valbinds . hs_valds'
> > gmake[1]: *** [utils/haddock/dist/build/Haddock/Interface/Create.dyn_o] Error 1
> > gmake: *** [all] Error 2
> >
> > Please consult the details at
> >
> > http://haskell.inf.elte.hu/builders/solaris-x86-head/28/10.html
>